Bug 62740
| Summary: | documentDidBecomeActive() is called twice for pages being restored from the page cache | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | achristensen, ahmad.saleem792, ap, beidson, bfulgham, cdumez, rniwa, zalan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
FrameLoader::commitProvisionalLoad() calls cachedPage->restore(m_frame->page()); which calls documentDidBecomeActive(). It then calls m_frame->document()->documentDidBecomeActive() a second time lower down.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
https://github.com/WebKit/WebKit/blob/7de67f9a0ccc4fc8ce195e32f61e7873ad81345e/Source/WebCore/loader/FrameLoader.cpp#L2016
Is this needed now or this logic has been reworked? Thanks!