Bug 62514

Summary: [Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
Product: WebKit Reporter: Robert Hogan <robert>
Component: New BugsAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, kling, ossy, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 62926    
Bug Blocks: 62929    
Attachments:
Description Flags
Patch
none
Patch none

Robert Hogan
Reported 2011-06-12 10:30:48 PDT
[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
Attachments
Patch (3.49 KB, patch)
2011-06-12 10:38 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Patch (3.41 KB, patch)
2011-06-18 03:33 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2011-06-12 10:38:23 PDT
Created attachment 96882 [details] Patch
Robert Hogan
Comment 2 2011-06-17 12:10:44 PDT
Committed r89154: <http://trac.webkit.org/changeset/89154>
Ryosuke Niwa
Comment 3 2011-06-17 16:39:15 PDT
It seems like this patch caused Qt Windows build failure: http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Debug/builds/24074/steps/compile-webkit/logs/stdio
Robert Hogan
Comment 4 2011-06-17 18:34:32 PDT
Whoops.i'll take a look in the morning.
Csaba Osztrogonác
Comment 5 2011-06-18 01:43:22 PDT
Robert, you should have watch the bots after landing instead of waiting if somebody kick in your ass. :) Please respect contributing rules and try to keep the tree green: http://www.webkit.org/coding/contributing.html "Your change must at least compile on all platforms." I had to roll it out to make the bots green again: http://trac.webkit.org/changeset/89191
Robert Hogan
Comment 6 2011-06-18 03:33:57 PDT
Created attachment 97695 [details] Patch
Alexey Proskuryakov
Comment 7 2011-06-18 09:34:52 PDT
Comment on attachment 97695 [details] Patch ok
WebKit Review Bot
Comment 8 2011-06-19 03:53:16 PDT
Comment on attachment 97695 [details] Patch Clearing flags on attachment: 97695 Committed r89213: <http://trac.webkit.org/changeset/89213>
WebKit Review Bot
Comment 9 2011-06-19 03:53:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.