Bug 62330

Summary: [Qt] JSC Bridge: convert QtConnectionObject to use JSC API
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60842    
Attachments:
Description Flags
Patch
none
Patch none

Caio Marcelo de Oliveira Filho
Reported 2011-06-08 14:52:57 PDT
[Qt] JSC Bridge: convert QtConnectionObject to use JSC API
Attachments
Patch (13.42 KB, patch)
2011-06-08 14:53 PDT, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
Patch (14.23 KB, patch)
2011-06-08 16:09 PDT, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-06-08 14:53:55 PDT
Created attachment 96488 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 2 2011-06-08 14:57:15 PDT
I think this patch is in a good shape to be reviewed, I still want to remove the limitation of 10 arguments, but it is a minor change.
Oliver Hunt
Comment 3 2011-06-08 15:12:21 PDT
Comment on attachment 96488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96488&action=review > Source/WebCore/bridge/qt/qt_runtime.h:224 > + JSObjectRef m_receiver; > + JSObjectRef m_receiverFunction; These used to be protected, and now they aren't -- you probably want to gcProtect/Unprotect these if you want to maintain the same semantics as those that already exist
Caio Marcelo de Oliveira Filho
Comment 4 2011-06-08 16:09:20 PDT
Created attachment 96503 [details] Patch
Oliver Hunt
Comment 5 2011-06-08 16:15:07 PDT
Comment on attachment 96503 [details] Patch This looks sensible to me, but i'll hold off on r+ for someone familiar with qt
Noam Rosenthal
Comment 6 2011-06-08 18:00:02 PDT
(In reply to comment #5) > (From update of attachment 96503 [details]) > This looks sensible to me, but i'll hold off on r+ for someone familiar with qt "dry" r=me (dry since I'm not yet a reviewer)
Andreas Kling
Comment 7 2011-06-09 13:04:23 PDT
Comment on attachment 96503 [details] Patch rs=me based on Noam's assessment.
WebKit Review Bot
Comment 8 2011-06-13 06:41:58 PDT
Comment on attachment 96503 [details] Patch Clearing flags on attachment: 96503 Committed r88635: <http://trac.webkit.org/changeset/88635>
WebKit Review Bot
Comment 9 2011-06-13 06:42:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.