Bug 62176

Summary: Change RenderBlock::hitTestFloats to IntPoint
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leviw, leviw, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2011-06-06 19:02:52 PDT
Ongoing tx, ty removal.
Attachments
Patch (4.89 KB, patch)
2011-06-06 19:05 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.85 KB, patch)
2011-06-07 16:23 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-06-06 19:05:47 PDT
Created attachment 96175 [details] Patch
Emil A Eklund
Comment 2 2011-06-07 14:49:22 PDT
Eric, did you miss this one in the flood of bug mail?
Eric Seidel (no email)
Comment 3 2011-06-07 14:56:13 PDT
Comment on attachment 96175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96175&action=review > Source/WebCore/rendering/RenderBlock.cpp:3964 > + adjustedLocation += IntSize(toRenderView(this)->frameView()->scrollX(), toRenderView(this)->frameView()->scrollY()); Should we be using a scrollLocation() function here?
Emil A Eklund
Comment 4 2011-06-07 14:56:32 PDT
Arhh, got the name wrong. This is about hitTestFloats. Not Columns.
Emil A Eklund
Comment 5 2011-06-07 16:23:35 PDT
Created attachment 96323 [details] Patch for landing
Emil A Eklund
Comment 6 2011-06-07 19:32:55 PDT
Landed r88317.
Note You need to log in before you can comment on or make changes to this bug.