Bug 62173

Summary: [EFL] Remove JSC dependency from WebKit/efl
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, kenneth, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60244    
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2011-06-06 18:18:27 PDT
patch will be updated.
Attachments
Patch (1.56 KB, patch)
2011-06-06 18:21 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2011-06-06 22:21 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-06-06 18:21:54 PDT
Created attachment 96169 [details] Patch
Antonio Gomes
Comment 2 2011-06-06 21:23:31 PDT
Comment on attachment 96169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96169&action=review > Source/WebKit/efl/ChangeLog:9 > + Change JSC::initializeThreading() and WTF::initializeMainThread() to > + WebCore::ScriptController::initializeThreading(). Could you explain why, please?
Ryuan Choi
Comment 3 2011-06-06 21:59:24 PDT
(In reply to comment #2) > (From update of attachment 96169 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96169&action=review > > > Source/WebKit/efl/ChangeLog:9 > > + Change JSC::initializeThreading() and WTF::initializeMainThread() to > > + WebCore::ScriptController::initializeThreading(). > > Could you explain why, please? ScriptController::initializeThreading() hide above two functions to build WebKit/EFL with v8. I can recreate this patch if you want to comment it in ChangeLog. :) Thanks.
Gyuyoung Kim
Comment 4 2011-06-06 22:02:46 PDT
Yes, you have to mention the reason in Changelog.
Ryuan Choi
Comment 5 2011-06-06 22:21:31 PDT
Created attachment 96204 [details] Patch
Ryuan Choi
Comment 6 2011-06-06 22:22:04 PDT
(In reply to comment #4) > Yes, you have to mention the reason in Changelog. Done.
Leandro Pereira
Comment 7 2011-06-07 07:37:37 PDT
Comment on attachment 96204 [details] Patch LGTM.
WebKit Commit Bot
Comment 8 2011-06-07 08:53:02 PDT
The commit-queue encountered the following flaky tests while processing attachment 96204 [details]: inspector/debugger/source-frame.html bug 57399 (author: podivilov@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2011-06-07 08:54:39 PDT
Comment on attachment 96204 [details] Patch Clearing flags on attachment: 96204 Committed r88241: <http://trac.webkit.org/changeset/88241>
WebKit Commit Bot
Comment 10 2011-06-07 08:54:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.