Bug 62037

Summary: Switch paintCaret and paintDragCaret to use IntPoint
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, darin, eae, eric, simon.fraser, simonjam, thakis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2011-06-03 12:02:21 PDT
Ongoing tx/ty removal.
Attachments
Patch (10.24 KB, patch)
2011-06-03 12:25 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-06-03 12:05:33 PDT
Two is today's magic number.
Levi Weintraub
Comment 2 2011-06-03 12:25:04 PDT
Created attachment 95944 [details] Patch
Levi Weintraub
Comment 3 2011-06-03 13:57:47 PDT
Comment on attachment 95944 [details] Patch Clearing flags on attachment: 95944 Committed r88050: <http://trac.webkit.org/changeset/88050>
Levi Weintraub
Comment 4 2011-06-03 13:57:51 PDT
All reviewed patches have been landed. Closing bug.
James Simonsen
Comment 5 2011-06-03 18:55:50 PDT
This caused the Mac Clang bot to fail. Can you take a look? http://build.chromium.org/p/chromium/builders/Mac%20Clang%20%28dbg%29/builds/3810/steps/compile/logs/stdio
Nico Weber
Comment 6 2011-06-03 19:30:04 PDT
Hi this breaks the clang build thusly: clang:warning: argument unused during compilation: '-fobjc-exceptions' /b/build/slave/Mac_Clang__dbg_/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../webaudio/AudioParamTimeline.cpp:231:39:error: operands of ? are integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare] int nextEventType = nextEvent ? nextEvent->type() : -1 /* unknown */; Can you fix?
Eric Seidel (no email)
Comment 7 2011-06-03 19:32:51 PDT
That can't be this change.
Nico Weber
Comment 8 2011-06-03 19:36:20 PDT
Sorry, meant to comment on bug 61830 9_9
Note You need to log in before you can comment on or make changes to this bug.