Bug 61884

Summary: Switch paintOverflowControls to use IntPoint
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 61883    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Levi Weintraub
Reported 2011-06-01 13:54:04 PDT
Ongoing tx/ty removal.
Attachments
Patch (7.46 KB, patch)
2011-06-01 14:49 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (7.46 KB, patch)
2011-06-01 14:54 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-06-01 14:49:16 PDT
Created attachment 95666 [details] Patch
Eric Seidel (no email)
Comment 2 2011-06-01 14:51:12 PDT
Comment on attachment 95666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95666&action=review > Source/WebCore/rendering/RenderLayer.cpp:2284 > + m_cachedOverlayScrollbarOffset = paintOffset; eeewww. Wonder why this exists. > Source/WebCore/rendering/RenderLayer.cpp:2295 > + adjustedPaintOffset.move(m_cachedOverlayScrollbarOffset); This doesn't look right. I think you meant =. > Source/WebCore/rendering/RenderLayerBacking.cpp:1105 > + int tx = layerBounds.x() - m_owningLayer->renderBoxX(); > + int ty = layerBounds.y() - m_owningLayer->renderBoxY(); I guess we're not ready to kill the tx, ty here yet? :)
Levi Weintraub
Comment 3 2011-06-01 14:53:31 PDT
Comment on attachment 95666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95666&action=review Thanks for the catch! >> Source/WebCore/rendering/RenderLayer.cpp:2284 >> + m_cachedOverlayScrollbarOffset = paintOffset; > > eeewww. Wonder why this exists. I'll second that... Seems pretty funky to me! >> Source/WebCore/rendering/RenderLayer.cpp:2295 >> + adjustedPaintOffset.move(m_cachedOverlayScrollbarOffset); > > This doesn't look right. I think you meant =. D'oh! Good catch! >> Source/WebCore/rendering/RenderLayerBacking.cpp:1105 >> + int ty = layerBounds.y() - m_owningLayer->renderBoxY(); > > I guess we're not ready to kill the tx, ty here yet? :) paintLayer will unfortunately probably be one of the last, but we're making great progress! :)
Levi Weintraub
Comment 4 2011-06-01 14:54:33 PDT
Created attachment 95668 [details] Patch
Eric Seidel (no email)
Comment 5 2011-06-01 15:51:00 PDT
Comment on attachment 95668 [details] Patch OK.
Levi Weintraub
Comment 6 2011-06-01 16:16:02 PDT
Comment on attachment 95668 [details] Patch Clearing flags on attachment: 95668 Committed r87864: <http://trac.webkit.org/changeset/87864>
Levi Weintraub
Comment 7 2011-06-01 16:16:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.