Bug 61682

Summary: Convert editing/pasteboard/paste-blockquote-into-blockquote-2.html to dump-as-markup
Product: WebKit Reporter: Annie Sullivan <sullivan>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61807, 34564    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Annie Sullivan
Reported 2011-05-27 20:03:24 PDT
The test output would be much easier to read as dump-as-markup.
Attachments
Patch (57.67 KB, patch)
2011-05-27 20:05 PDT, Annie Sullivan 		no flags
DetailsFormatted DiffDiff
Patch (57.96 KB, patch)
2011-05-31 14:43 PDT, Annie Sullivan 		no flags
DetailsFormatted DiffDiff
Patch (57.93 KB, patch)
2011-05-31 14:56 PDT, Annie Sullivan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Annie Sullivan
Comment 1 2011-05-27 20:05:28 PDT
Created attachment 95250 [details] Patch
Ryosuke Niwa
Comment 2 2011-05-28 18:40:59 PDT
Comment on attachment 95250 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95250&action=review > LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:1 > +This tests pasting a nested blockquote into a blockquote. The first line below should be singly-blockquoted, and the second should be doubly-blockquoted. I'd rather explicitly say that "One" should be singly-blockquoted and "Two" and "Three" should be doubly-blockquoted. And it seems like there's a bug here. Two is somehow singly-blockquoted. Please file a bug and make it depend on this bug.
Annie Sullivan
Comment 3 2011-05-31 14:04:58 PDT
Comment on attachment 95250 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95250&action=review >> LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:1 >> +This tests pasting a nested blockquote into a blockquote. The first line below should be singly-blockquoted, and the second should be doubly-blockquoted. > > I'd rather explicitly say that "One" should be singly-blockquoted and "Two" and "Three" should be doubly-blockquoted. And it seems like there's a bug here. Two is somehow singly-blockquoted. Please file a bug and make it depend on this bug. Bug filed. Looks like this behavior has been there since the test was created. I'll update the description to clarify what the behavior is, and mention the bug.
Annie Sullivan
Comment 4 2011-05-31 14:43:14 PDT
Created attachment 95486 [details] Patch
Ryosuke Niwa
Comment 5 2011-05-31 14:49:12 PDT
Comment on attachment 95486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95486&action=review > LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:1 > +This tests pasting a nested blockquote into a blockquote. The text "One" should be singly-blockquoted, and the text "Two Three" should be doubly-blockquoted. However, currently "One Two" is singly blockquoted and "Three" is doubly-blockquoted. See bug 61807. You probably want to put "-" between singly and blockquoted. > LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-2.html:26 > +Markup.description("This tests pasting a nested blockquote into a blockquote. " + > + "The text \"One\" should be singly-blockquoted, and the text \"Two Three\" should be doubly-blockquoted. " + > + "However, currently \"One Two\" is singly blockquoted and \"Three\" is doubly-blockquoted. See bug 61807."); We don't normally indent text like this. Please just indent 4 spaces on the second and the third line. Also + should be on the next line not on the previous line (the indentation should be before +).
Annie Sullivan
Comment 6 2011-05-31 14:56:00 PDT
Created attachment 95488 [details] Patch
WebKit Commit Bot
Comment 7 2011-05-31 23:18:58 PDT
Comment on attachment 95488 [details] Patch Clearing flags on attachment: 95488 Committed r87775: <http://trac.webkit.org/changeset/87775>
WebKit Commit Bot
Comment 8 2011-05-31 23:19:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.