Bug 61617

Summary: Convert smart-paste-001.html through smart-paste-003.html to dumpAsText tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enrica, morrita, ojan, tkent, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 34564    
Attachments:
Description Flags
converts the tests
none
fixed this this none

Ryosuke Niwa
Reported 2011-05-27 01:31:42 PDT
The following tests should be converted to dumpAsText tests to that the outputs can easily be understood. editing/pasteboard/smart-paste-001.html editing/pasteboard/smart-paste-002.html editing/pasteboard/smart-paste-003.html
Attachments
converts the tests (65.80 KB, patch)
2011-05-27 01:35 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
fixed this this (66.90 KB, patch)
2011-05-27 01:54 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-05-27 01:35:25 PDT
Created attachment 95141 [details] converts the tests
Kent Tamura
Comment 2 2011-05-27 01:40:28 PDT
Comment on attachment 95141 [details] converts the tests View in context: https://bugs.webkit.org/attachment.cgi?id=95141&action=review > LayoutTests/editing/pasteboard/smart-paste-001-expected.txt:14 > +A space should be added between the preexisting word and the word that's pasted. It should like this this: Extra 'this'? > LayoutTests/editing/pasteboard/smart-paste-002-expected.txt:17 > +A space should be added after the pasted word before the preexising word. It should like this this: ditto. > LayoutTests/editing/pasteboard/smart-paste-003-expected.txt:16 > +A space should be added between the preexisting word and the word that's pasted. No space should be added after the pasted word. It should like this this: ditto.
Ryosuke Niwa
Comment 3 2011-05-27 01:48:09 PDT
Comment on attachment 95141 [details] converts the tests View in context: https://bugs.webkit.org/attachment.cgi?id=95141&action=review >> LayoutTests/editing/pasteboard/smart-paste-001-expected.txt:14 >> +A space should be added between the preexisting word and the word that's pasted. It should like this this: > > Extra 'this'? This is coming from the original test but I'll fix in a minute.
Ryosuke Niwa
Comment 4 2011-05-27 01:54:44 PDT
Created attachment 95145 [details] fixed this this
WebKit Commit Bot
Comment 5 2011-05-27 04:39:03 PDT
Comment on attachment 95145 [details] fixed this this Clearing flags on attachment: 95145 Committed r87495: <http://trac.webkit.org/changeset/87495>
WebKit Commit Bot
Comment 6 2011-05-27 04:39:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.