Bug 61597

Summary: editing/pasteboard/5089327.html should be renamed and converted to a dump-as-markup test
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric, morrita, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 34564    
Attachments:
Description Flags
61597 none

Ryosuke Niwa
Reported 2011-05-26 19:56:27 PDT
We should give editing/pasteboard/4700297.html a more descriptive name and convert it to a dump-as-markup test.
Attachments
61597 (12.99 KB, patch)
2011-05-26 20:09 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-05-26 20:09:33 PDT
Created attachment 95100 [details] 61597
Eric Seidel (no email)
Comment 2 2011-05-26 20:23:06 PDT
Comment on attachment 95100 [details] 61597 OK.
Ryosuke Niwa
Comment 3 2011-05-26 20:27:14 PDT
Comment on attachment 95100 [details] 61597 Thanks for the reviews!
Ryosuke Niwa
Comment 4 2011-05-26 22:30:01 PDT
Comment on attachment 95100 [details] 61597 Clearing flags on attachment: 95100 Committed r87470: <http://trac.webkit.org/changeset/87470>
Ryosuke Niwa
Comment 5 2011-05-26 22:30:06 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2011-05-27 17:08:03 PDT
I don't see anything blue in this test's new expected result :-) +This tests to make sure that content that has the document default color is pasted as blue +(or whatever the color for quoted content is) when pasted in the middle of quoted content. +| <blockquote> +| type="cite" +| <div> +| "(" +| "This text should be blue.<#selection-caret>" +| ")"
Ryosuke Niwa
Comment 7 2011-05-27 17:10:50 PDT
(In reply to comment #6) > I don't see anything blue in this test's new expected result :-) > > +This tests to make sure that content that has the document default color is pasted as blue > +(or whatever the color for quoted content is) when pasted in the middle of quoted content. > +| <blockquote> > +| type="cite" > +| <div> > +| "(" > +| "This text should be blue.<#selection-caret>" > +| ")" Yeah, I thought about this for a while but "whatever the color for quoted content is" seems to clarify this point. I'm more than happy to change if you come up with a better description.
Note You need to log in before you can comment on or make changes to this bug.