Bug 61245

Summary: When removing a shadow root from DOM, also remove it from the render tree
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Dominic Cooney <dominicc>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 59571    
Attachments:
Description Flags
Patch none

Dominic Cooney
Reported 2011-05-22 02:32:01 PDT
I have diagnosed the cause of the crashes discussed in bug 59571 as a shadow root remaining in the render tree after it is removed from the DOM. When a shadow root is removed from the DOM, it should also be removed from the render tree.
Attachments
Patch (2.57 KB, patch)
2011-05-22 02:40 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-05-22 02:40:49 PDT
Created attachment 94338 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-05-22 07:51:04 PDT
Comment on attachment 94338 [details] Patch OMG. Good find.
WebKit Commit Bot
Comment 3 2011-05-22 08:56:16 PDT
Comment on attachment 94338 [details] Patch Clearing flags on attachment: 94338 Committed r87029: <http://trac.webkit.org/changeset/87029>
WebKit Commit Bot
Comment 4 2011-05-22 08:56:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.