Bug 60923

Summary: editing/pasteboard/5075944-2.html and 5075944-3.html should be renamed and converted to dump-as-markup tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, ademar, enrica, ojan, sullivan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60914    
Attachments:
Description Flags
converted tests enrica: review+

Ryosuke Niwa
Reported 2011-05-16 14:20:37 PDT
5075944-2.html needs to verify the color of the underline but render tree dump can't capture this information. We should convert this test to a dump-as-markup test so that we can see text diff when it regresses. Also, we should give it a more descriptive name.
Attachments
converted tests (18.55 KB, patch)
2011-05-16 15:09 PDT, Ryosuke Niwa 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-05-16 14:22:06 PDT
Ditto: 5075944-3.html
Ryosuke Niwa
Comment 2 2011-05-16 15:09:05 PDT
Created attachment 93702 [details] converted tests
Enrica Casucci
Comment 3 2011-05-16 15:31:31 PDT
Comment on attachment 93702 [details] converted tests Do you need results for the windows build?
Ryosuke Niwa
Comment 4 2011-05-16 15:35:20 PDT
(In reply to comment #3) > (From update of attachment 93702 [details]) > Do you need results for the windows build? I don't think so. By the way, I realized that I forgot to remove old expected results for 5075944-3.html. Will remove before landing the patch.
Ryosuke Niwa
Comment 5 2011-05-16 15:42:24 PDT
Thanks for the review, Enrica! Landing it now.
Ryosuke Niwa
Comment 6 2011-05-16 15:46:34 PDT
Committed r86619: <http://trac.webkit.org/changeset/86619>
Ademar Reis
Comment 7 2011-05-23 14:08:00 PDT
Revision r86619 cherry-picked into qtwebkit-2.2 with commit d75ec39 <http://gitorious.org/webkit/qtwebkit/commit/d75ec39>
Ademar Reis
Comment 8 2011-05-26 15:40:23 PDT
Revision r86619 cherry-picked into qtwebkit-2.2 with commit d18ba15 <http://gitorious.org/webkit/qtwebkit/commit/d18ba15>
Note You need to log in before you can comment on or make changes to this bug.