Bug 60297

Summary: Add cmd line flag to chromium version of DumpRenderTree to select GraphicsContext3D implementation
Product: WebKit Reporter: Gregg Tavares <gman>
Component: Tools / TestsAssignee: Gregg Tavares <gman>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, dglazkov, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gregg Tavares
Reported 2011-05-05 14:08:05 PDT
Add cmd line flag to chromium version of DumpRenderTree to select GraphicsContext3D implementation I'll submit a patch for this asap.
Attachments
Patch (2.45 KB, patch)
2011-05-05 16:06 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (2.37 KB, patch)
2011-05-12 14:54 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2011-05-12 15:48 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gregg Tavares
Comment 1 2011-05-05 16:06:10 PDT
Created attachment 92489 [details] Patch
Kenneth Russell
Comment 2 2011-05-05 17:31:18 PDT
Comment on attachment 92489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92489&action=review Looks good except for the "reviewed by" line. Please upload another version fixing that issue and we can submit it via the commit queue. > ChangeLog:3 > + Reviewed by Kenneth Russell Actually you should leave this line as "Reviewed by NOBODY (OOPS)!". The tools will fill in the reviewer's name. All other lines containing OOPS need to be addressed or removed. > ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=60297 In the future, the preferred format is: [synopsis] [bug ID] but this is fine.
Gregg Tavares
Comment 3 2011-05-12 14:54:11 PDT
Created attachment 93348 [details] Patch
Kenneth Russell
Comment 4 2011-05-12 15:05:13 PDT
Comment on attachment 93348 [details] Patch Looks good to me.
WebKit Review Bot
Comment 5 2011-05-12 15:33:42 PDT
Comment on attachment 93348 [details] Patch Attachment 93348 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8689833
Gregg Tavares
Comment 6 2011-05-12 15:48:49 PDT
Created attachment 93360 [details] Patch
Kenneth Russell
Comment 7 2011-05-12 16:27:58 PDT
Comment on attachment 93360 [details] Patch Looks like it passed the EWS bot; let's try again.
WebKit Commit Bot
Comment 8 2011-05-12 16:49:10 PDT
The commit-queue encountered the following flaky tests while processing attachment 93348 [details]: java/lc3/JavaObject/JavaObjectToByte-006.html bug 60333 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2011-05-12 17:19:18 PDT
Comment on attachment 93360 [details] Patch Clearing flags on attachment: 93360 Committed r86403: <http://trac.webkit.org/changeset/86403>
WebKit Commit Bot
Comment 10 2011-05-12 17:19:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.