Bug 60162

Summary: [NRWT] chromium-linux tests shouldn't run on other platforms
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Kristóf Kosztyó <kkristof>
Status: RESOLVED FIXED    
Severity: Normal CC: kkristof, ossy, rgabor
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
proposed fix none

Csaba Osztrogonác
Reported 2011-05-04 05:56:42 PDT
These tests run, but they shouldn't: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Gábor, could you check it, please?
Attachments
proposed fix (3.49 KB, patch)
2011-05-13 07:40 PDT, Kristóf Kosztyó 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kristóf Kosztyó
Comment 1 2011-05-13 07:40:31 PDT
Created attachment 93449 [details] proposed fix
Csaba Osztrogonác
Comment 2 2011-05-13 07:43:49 PDT
Comment on attachment 93449 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=93449&action=review LGTM, r=me with a little fix in changelog > Tools/ChangeLog:9 > + Remove _tests_for_other_platforms defs because in the r82753 > + it is implemented properly in the baseclass in webkit.py little nit: ... because r82753 implemented it properly ...
Csaba Osztrogonác
Comment 3 2011-05-13 07:48:57 PDT
Landed in http://trac.webkit.org/changeset/86429
Note You need to log in before you can comment on or make changes to this bug.