Bug 60034

Summary: Implement LayoutTestController::pseudoShadowId()
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, buildbot, dominicc, eric, fischman, rolandsteiner
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 28220, 59661    
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch
none
proposed patch
none
proposed patch dglazkov: review+

Philippe Normand
Reported 2011-05-03 09:51:48 PDT
+++ This bug was initially created as a clone of Bug #58584 +++ Authors should be able to read and write the shadowPseudoId property on an element. A new LayoutTestController method is needed so test authors can get the shadowPseudoId of a given Node.
Attachments
proposed patch (24.51 KB, patch)
2011-05-04 09:34 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (24.50 KB, patch)
2011-05-04 09:38 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (32.22 KB, patch)
2011-05-05 00:48 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (32.81 KB, patch)
2011-05-05 02:03 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (33.18 KB, patch)
2011-05-05 03:02 PDT, Philippe Normand 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-05-04 09:34:38 PDT
Created attachment 92258 [details] proposed patch I tested this on GTK, chromium-linux, qt-linux and mac. Not on windows though.
Eric Seidel (no email)
Comment 2 2011-05-04 09:35:23 PDT
Attachment 92258 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1 Tools/DumpRenderTree/LayoutTestController.h:78: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 3 2011-05-04 09:38:08 PDT
Created attachment 92259 [details] proposed patch
Dimitri Glazkov (Google)
Comment 4 2011-05-04 09:40:41 PDT
Comment on attachment 92259 [details] proposed patch This looks great! I think you're still missing changes to WebKitRunner for WebKit2?
Philippe Normand
Comment 5 2011-05-04 09:44:40 PDT
(In reply to comment #4) > (From update of attachment 92259 [details]) > This looks great! I think you're still missing changes to WebKitRunner for WebKit2? Oh, true! I didn't know about that. New LayoutTestControllers to patch indeed :)
Philippe Normand
Comment 6 2011-05-04 09:49:08 PDT
Comment on attachment 92259 [details] proposed patch Incomplete patch
Build Bot
Comment 7 2011-05-04 10:13:54 PDT
Attachment 92259 [details] did not build on win: Build output: http://queues.webkit.org/results/8558556
Philippe Normand
Comment 8 2011-05-05 00:48:08 PDT
Created attachment 92384 [details] proposed patch
Build Bot
Comment 9 2011-05-05 01:27:17 PDT
Attachment 92384 [details] did not build on win: Build output: http://queues.webkit.org/results/8557859
Philippe Normand
Comment 10 2011-05-05 02:03:14 PDT
Created attachment 92389 [details] proposed patch Trying to make win EWS happy about this.
Build Bot
Comment 11 2011-05-05 02:28:38 PDT
Attachment 92389 [details] did not build on win: Build output: http://queues.webkit.org/results/8554845
Philippe Normand
Comment 12 2011-05-05 02:47:23 PDT
(In reply to comment #11) > Attachment 92389 [details] did not build on win: > Build output: http://queues.webkit.org/results/8554845 Adam, would you mind checking my patch? It doesn't build on windows although I registered the new shadowPseudoId method in the IDOMElementPrivate interface... Not sure what to do about this and I don't have a windows box.
Philippe Normand
Comment 13 2011-05-05 03:02:07 PDT
Created attachment 92397 [details] proposed patch Touched Source/WebKit/win/Interfaces/WebKit.idl in the secret hope this will trigger a magic rebuild in win EWS and turn the bubble to green!
Philippe Normand
Comment 14 2011-05-05 03:54:26 PDT
(In reply to comment #13) > Created an attachment (id=92397) [details] > proposed patch > > Touched Source/WebKit/win/Interfaces/WebKit.idl > in the secret hope this will trigger a magic rebuild in win EWS and > turn the bubble to green! Sweet this worked \o/
Dimitri Glazkov (Google)
Comment 15 2011-05-05 09:15:18 PDT
Comment on attachment 92397 [details] proposed patch ok. Even though I am embarking on the journey to move these methods to window.internals, I am not going to block your progress on it.
Philippe Normand
Comment 16 2011-05-06 00:29:13 PDT
Committed r85925: <http://trac.webkit.org/changeset/85925>
Note You need to log in before you can comment on or make changes to this bug.