Bug 59886

Summary: REGRESSIONS (r71934, r74787): In standalone media documents, (double-)clicking the media element doesn’t play/pause, clicking outside it does
Product: WebKit Reporter: mitz
Component: MediaAssignee: Abhishek Arya <inferno>
Status: RESOLVED FIXED    
Severity: Major CC: dglazkov, eric.carlson, inferno
Priority: P1 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov
Bug Depends on: 59976    
Bug Blocks:    
Attachments:
Description Flags
Patch eric.carlson: review+

mitz
Reported 2011-05-01 13:28:50 PDT
<rdar://problem/9319469> In a standalone media document, such as the URL, clicking the video element should pause it and double-clicking it should resume playback. Clicking and double-clicking in the background should have no effect. r71934 broke the clicking/double-clicking the video behavior. r74787 made it so clicking/double-clicking the background pauses/plays the video. Both are wrong.
Attachments
Patch (2.49 KB, patch)
2011-05-01 16:36 PDT, Abhishek Arya 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2011-05-01 13:33:21 PDT
The mistake in r74787 is obvious (not checking the target element).
Abhishek Arya
Comment 2 2011-05-01 15:59:40 PDT
Sorry about the regression. I accidently assumed the descendant node check on mouse click, double click events(code cleanup) while fixing a sec bug on key down event which does do the descendants check on target node. uploading a fix soon.
Abhishek Arya
Comment 3 2011-05-01 16:36:28 PDT
Created attachment 91859 [details] Patch
Abhishek Arya
Comment 4 2011-05-01 22:59:56 PDT
Committed r85458: <http://trac.webkit.org/changeset/85458>
Abhishek Arya
Comment 5 2011-05-01 23:01:05 PDT
Thank you Eric. Filed https://bugs.webkit.org/show_bug.cgi?id=59917 to cover regression from r71934.
Note You need to log in before you can comment on or make changes to this bug.