Bug 59462

Summary: [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
Product: WebKit Reporter: Siddharth Mathur <s.mathur>
Component: WebKit2Assignee: Siddharth Mathur <s.mathur>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kbalazs, kenneth, laszlo.gombos
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 50251    
Attachments:
Description Flags
Patch
none
Patch
none
Updated patch with for Symbian executable properties only none

Siddharth Mathur
Reported 2011-04-26 08:20:06 PDT
Add commonly used capabilities such as a ReadDeviceData and WriteDeviceData. Qt mobility seems to require a few of them, see table here: http://doc.qt.nokia.com/qtmobility/quickstart.html - The Location capability is only being added to UI process and not web process - PowerManagement is being added to UI process, so that web process can be killed via RProcess::Terminate(). * Also added data paging flag * Minor edits in the UI to help with smaller buttons and neater layout on a small device.
Attachments
Patch (4.25 KB, patch)
2011-04-26 08:27 PDT, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
Patch (1.86 KB, patch)
2011-05-04 08:05 PDT, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
Updated patch with for Symbian executable properties only (3.19 KB, patch)
2011-05-04 08:19 PDT, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Siddharth Mathur
Comment 1 2011-04-26 08:27:45 PDT
Created attachment 91110 [details] Patch
Andreas Kling
Comment 2 2011-04-26 10:19:11 PDT
Comment on attachment 91110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91110&action=review > Source/WebKit2/ChangeLog:5 > + [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian + Minor UI changes The two changesets are completely unrelated and should be split up into separate patches. > Tools/MiniBrowser/qt/MiniBrowser.pro:59 > + # http://doc.qt.nokia.com/qtmobility/quickstart.html Out of curiosity, is there no way to express that you're using QtMobility and therefore require the capabilities used by that library?
Siddharth Mathur
Comment 3 2011-05-04 08:05:16 PDT
Created attachment 92240 [details] Patch
Siddharth Mathur
Comment 4 2011-05-04 08:06:21 PDT
Comment on attachment 92240 [details] Patch Hmm, webkit-patch user error. sorry.
Siddharth Mathur
Comment 5 2011-05-04 08:19:19 PDT
Created attachment 92243 [details] Updated patch with for Symbian executable properties only
Laszlo Gombos
Comment 6 2011-05-04 15:32:44 PDT
Comment on attachment 92243 [details] Updated patch with for Symbian executable properties only lgtm, r+.
WebKit Commit Bot
Comment 7 2011-05-04 16:26:42 PDT
Comment on attachment 92243 [details] Updated patch with for Symbian executable properties only Clearing flags on attachment: 92243 Committed r85803: <http://trac.webkit.org/changeset/85803>
WebKit Commit Bot
Comment 8 2011-05-04 16:26:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.