Bug 59345

Summary: [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, cmarcelo, commit-queue, kenneth, ossy, rafael.lobo
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 38654    
Attachments:
Description Flags
mark failing test cases as expected fail
none
Patch none

Csaba Osztrogonác
Reported 2011-04-25 14:28:07 PDT
original bug: Handling of URLs like http:/example.com/ is incorrect https://bugs.webkit.org/show_bug.cgi?id=59300 http://trac.webkit.org/changeset/84762 fail: ------ FAIL! : tst_QWebFrame::setUrlToInvalid() Compared values are not the same Actual (frame->url()): http://here/ Expected (invalidUrl): http:/here Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(3460)] -----
Attachments
mark failing test cases as expected fail (1.44 KB, patch)
2011-05-19 07:53 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (3.65 KB, patch)
2011-05-29 14:23 PDT, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-05-18 05:04:08 PDT
updated error message with r86748: FAIL! : tst_QWebFrame::setUrlToInvalid() Compared values are not the same Actual (frame->url()): http://here/ Expected (invalidUrl): http:/here Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(3462)]
Csaba Osztrogonác
Comment 2 2011-05-19 07:53:21 PDT
Created attachment 94069 [details] mark failing test cases as expected fail This is a month old regression, so it is time to mark the failing test cases as expected fail to make buildbot happier. We can easily catch regressions if all tests passes on the bot.
WebKit Commit Bot
Comment 3 2011-05-20 06:30:18 PDT
The commit-queue encountered the following flaky tests while processing attachment 94069 [details]: inspector/debugger/source-frame.html bug 57399 (author: podivilov@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-05-20 06:32:17 PDT
Comment on attachment 94069 [details] mark failing test cases as expected fail Clearing flags on attachment: 94069 Committed r86946: <http://trac.webkit.org/changeset/86946>
WebKit Commit Bot
Comment 5 2011-05-20 06:32:22 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2011-05-20 06:34:33 PDT
Reopen to fix the bug.
WebKit Commit Bot
Comment 7 2011-05-20 06:54:01 PDT
The commit-queue encountered the following flaky tests while processing attachment 94069 [details]: animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com) The commit-queue is continuing to process your patch.
Caio Marcelo de Oliveira Filho
Comment 8 2011-05-29 14:23:30 PDT
Created attachment 95300 [details] Patch
Kenneth Rohde Christiansen
Comment 9 2011-05-29 14:27:53 PDT
Comment on attachment 95300 [details] Patch ok
Kenneth Rohde Christiansen
Comment 10 2011-05-29 14:28:36 PDT
Comment on attachment 95300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > + const QUrl validUrl("http://example.com/"); Shouldnt this be with one / then? or
Caio Marcelo de Oliveira Filho
Comment 11 2011-05-30 08:44:55 PDT
(In reply to comment #10) > (From update of attachment 95300 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > > > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > > + const QUrl validUrl("http://example.com/"); > > Shouldnt this be with one / then? or No, this one is the valid URL that QWebFrame will end up with when you feed with the invalid one. So all url() and family will have the valid one now.
Kenneth Rohde Christiansen
Comment 12 2011-06-01 07:14:35 PDT
(In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 95300 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > > > > > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > > > + const QUrl validUrl("http://example.com/"); > > > > Shouldnt this be with one / then? or > > No, this one is the valid URL that QWebFrame will end up with when you feed with the invalid one. So all url() and family will have the valid one now. ok fine :-) pls commit
WebKit Commit Bot
Comment 13 2011-06-01 09:58:50 PDT
Comment on attachment 95300 [details] Patch Clearing flags on attachment: 95300 Committed r87818: <http://trac.webkit.org/changeset/87818>
WebKit Commit Bot
Comment 14 2011-06-01 09:58:56 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 15 2011-06-01 10:27:11 PDT
The commit-queue encountered the following flaky tests while processing attachment 95300 [details]: http/tests/websocket/tests/frame-length-longer-than-buffer.html bug 61837 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
Ademar Reis
Comment 16 2011-06-01 12:32:26 PDT
Revision r86946 cherry-picked into qtwebkit-2.2 with commit 8234285 <http://gitorious.org/webkit/qtwebkit/commit/8234285> Revision r87818 cherry-picked into qtwebkit-2.2 with commit 0c7056f <http://gitorious.org/webkit/qtwebkit/commit/0c7056f>
Note You need to log in before you can comment on or make changes to this bug.