Bug 59087

Summary: Centralize typedef unsigned short Glyph in Glyph.h
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 59085    
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v3 krit: review+

Nikolas Zimmermann
Reported 2011-04-21 03:10:39 PDT
Centralize typedef unsigned short Glyph in Glyph.h
Attachments
Patch (9.46 KB, patch)
2011-04-21 03:29 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (9.69 KB, patch)
2011-04-21 03:49 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v3 (9.73 KB, patch)
2011-04-21 04:37 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2011-04-21 03:29:49 PDT
Created attachment 90507 [details] Patch
Nikolas Zimmermann
Comment 2 2011-04-21 03:49:03 PDT
Created attachment 90508 [details] Patch v2 Oops, the first patch got truncated.
WebKit Review Bot
Comment 3 2011-04-21 04:30:32 PDT
Attachment 90507 [details] did not build on mac: Build output: http://queues.webkit.org/results/8486418
Nikolas Zimmermann
Comment 4 2011-04-21 04:37:58 PDT
Created attachment 90510 [details] Patch v3 Set Glyph.h role to private -- accidently reverted this part of WebCore.xcodeproj, while splitting up my large master patch in smaller chunks.
WebKit Review Bot
Comment 5 2011-04-21 05:31:43 PDT
Attachment 90508 [details] did not build on mac: Build output: http://queues.webkit.org/results/8493125
Dirk Schulze
Comment 6 2011-04-21 06:06:50 PDT
Comment on attachment 90510 [details] Patch v3 A lot content for one patch ;-) r=me
Nikolas Zimmermann
Comment 7 2011-04-21 06:08:03 PDT
Landed in r84489.
Note You need to log in before you can comment on or make changes to this bug.