Bug 58679

Summary:

The GTest framework should not use MacOSX10.4u.sdk

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

ASSIGNED

Severity:

Normal

CC:

dslomov, eric, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Fixing gtest configuration	levin: review-
Fixing gtest configuration	levin: review-

Timothy Hatcher

Reported 2011-04-15 11:58:35 PDT

Using it causes warnings on systems that don't have $(DEVELOPER_SDK_DIR)/MacOSX10.4u.sdk. It should not have an SDK and use the current system.

Attachments
Fixing gtest configuration (3.38 KB, patch) 2011-04-15 14:14 PDT, Dmitry Lomov	levin: review-	Details Formatted Diff Diff
Fixing gtest configuration (3.89 KB, patch) 2011-04-15 14:45 PDT, Dmitry Lomov	levin: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2011-04-15 12:07:34 PDT

Using GCC_VERSION = 4.0 is also a warning.

David Levin

Comment 2 2011-04-15 12:47:05 PDT

Dimitry is working on this shortly (today). If this is causing you grief, feel free to roll out r83974 and it can be put back with an appropriate fix.

Dmitry Lomov

Comment 3 2011-04-15 14:14:24 PDT

Created attachment 89851 [details] Fixing gtest configuration Modified definitions for SDKPATH and GCC_VERSION in Source/ThirdParty/gtest/xcode/Config/General.xcconfig to: * bring them in line with the rest of WebKit * not require MacOS 10.4 SDK and gcc 4.0 Dropped support of ppc and ppc64 for checked-in GTest

David Levin

Comment 4 2011-04-15 14:17:22 PDT

Comment on attachment 89851 [details] Fixing gtest configuration View in context: https://bugs.webkit.org/attachment.cgi?id=89851&action=review README.WebKit is good but you still need a ChangeLog. > Source/ThirdParty/gtest/xcode/Config/General.xcconfig:39 > +// number. Newer versions of Xcode use XCODE_VERSION_MINOR for the minor version, and Single space after . for WebKit. > Source/ThirdParty/gtest/xcode/Config/General.xcconfig:63 > +// If the target Mac OS X version does not match the current Mac OS X version then we'll want to build using the target version's SDK. Add , before then.

Dmitry Lomov

Comment 5 2011-04-15 14:45:43 PDT

Created attachment 89858 [details] Fixing gtest configuration CR feedback addressed

David Levin

Comment 6 2011-04-15 17:53:12 PDT

Comment on attachment 89858 [details] Fixing gtest configuration Rolling out the change that this depends on.

Eric Seidel (no email)

Comment 7 2012-10-16 22:07:51 PDT

Looks like this got forgotten? Or maybe silently fixed?

Note You need to log in before you can comment on or make changes to this bug.