Bug 58651

Summary: [Qt][Symbian] Need to export ViewportAttributes class
Product: WebKit Reporter: Nancy Piedra <nancy.piedra>
Component: WebKit QtAssignee: Nancy Piedra <nancy.piedra>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
Export ViewportAttributes class none

Nancy Piedra
Reported 2011-04-15 05:05:57 PDT
On Symbian build for ARM it seems we need to export the ViewportAttributes class. Otherwise, we get linking errors. I will upload a patch soon.
Attachments
Export ViewportAttributes class (1.18 KB, patch)
2011-04-15 05:43 PDT, Nancy Piedra 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nancy Piedra
Comment 1 2011-04-15 05:43:52 PDT
Created attachment 89771 [details] Export ViewportAttributes class On Symbian, the ViewportAttributes class needs to be exported otherwise there will be linking errors.
Laszlo Gombos
Comment 2 2011-04-15 06:40:53 PDT
Comment on attachment 89771 [details] Export ViewportAttributes class r=me.
WebKit Commit Bot
Comment 3 2011-04-15 09:17:26 PDT
The commit-queue encountered the following flaky tests while processing attachment 89771 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-04-15 09:20:21 PDT
Comment on attachment 89771 [details] Export ViewportAttributes class Clearing flags on attachment: 89771 Committed r83982: <http://trac.webkit.org/changeset/83982>
WebKit Commit Bot
Comment 5 2011-04-15 09:20:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.