Bug 58315

Summary: REGRESSION (r81479): generate-inspector-idl fails on native win32
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 56294    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2011-04-12 05:37:48 PDT
generate-inspector-idl fails if Inspector.json contains carriage return characters. You get them if you use a _git_ checkout with autocrlf enabled. To solve this we can: a) Add "-crlf" git attribute in ".gitattributes" b) Replace '\r\n' before passing the content to eval c) Use a JSON parser
Attachments
Patch (1.25 KB, patch)
2011-04-17 10:23 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-04-17 10:23:07 PDT
Created attachment 89950 [details] Patch
WebKit Commit Bot
Comment 2 2011-04-18 04:27:12 PDT
The commit-queue encountered the following flaky tests while processing attachment 89950 [details]: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2011-04-18 04:29:31 PDT
Comment on attachment 89950 [details] Patch Clearing flags on attachment: 89950 Committed r84130: <http://trac.webkit.org/changeset/84130>
WebKit Commit Bot
Comment 4 2011-04-18 04:29:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.