Bug 5826

Summary:

Blocks with direction:rtl and overflow:auto or scroll have incorrect scrollbars

Product:

WebKit

Reporter:

mitz

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

VERIFIED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
testcase	none
Proposed patch	mjs: review+
Improved testcase, in patch form	none
expected result for the pixel test	none

mitz

Reported 2005-11-25 11:25:34 PST

For blocks with direction:rtl and overflow:auto or scroll, the scrollable area should consist of the right corner of the block and any overflow to the left and down, and none of the overflow to the right. The initially visible area should be the right side of the scrollable area (i.e. the scrollbar should be all the way to the right). (This mirrors the behavior for ltr blocks). In the testcase, the scrollable areas for the top 5 cases should mirror those of the bottom 5 cases.

Attachments
testcase (1.99 KB, text/html) 2005-11-25 11:26 PST, mitz	no flags	Details
Proposed patch (7.98 KB, patch) 2005-11-25 11:28 PST, mitz	mjs: review+	Details Formatted Diff Diff
Improved testcase, in patch form (10.05 KB, patch) 2005-11-30 08:46 PST, mitz	no flags	Details Formatted Diff Diff
expected result for the pixel test (51.49 KB, image/png) 2005-11-30 08:48 PST, mitz	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2005-11-25 11:26:36 PST

Created attachment 4798 [details] testcase

mitz

Comment 2 2005-11-25 11:28:29 PST

Created attachment 4799 [details] Proposed patch

Darin Adler

Comment 3 2005-11-25 13:47:29 PST

Comment on attachment 4799 [details] Proposed patch Looks good, but I'd like Dave Hyatt to review this one.

Dave Hyatt

Comment 4 2005-11-26 00:04:45 PST

Did you leave the scrollbar on the far right, or did you move it to the far left like WinIE does?

mitz

Comment 5 2005-11-26 00:25:10 PST

(In reply to comment #4) > Did you leave the scrollbar on the far right, or did you move it to the far left like WinIE does? I left the vertical scrollbar on the far right. This is the Mac OS X way :-)

Maciej Stachowiak

Comment 6 2005-11-28 14:11:55 PST

Comment on attachment 4799 [details] Proposed patch hyatt says it's ok

Eric Seidel (no email)

Comment 7 2005-11-29 18:24:15 PST

It's not clear to me from the test case what is right or wrong, but I have not applied the patch yet.

mitz

Comment 8 2005-11-30 08:46:23 PST

Created attachment 4874 [details] Improved testcase, in patch form

mitz

Comment 9 2005-11-30 08:48:05 PST

Created attachment 4875 [details] expected result for the pixel test

Note You need to log in before you can comment on or make changes to this bug.