Bug 57415

Summary: Expose shadowRoot to JSC in DumpRenderTree tests
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric.carlson, eric, fischman, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 56573    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dominic Cooney
Reported 2011-03-29 19:03:53 PDT
JavaScript can not access shadow DOM, however DumpRenderTree tests should be able to access shadow DOM to make programmatic assertions about shadow DOM. I’m filing this to track the Mac port.
Attachments
Patch (14.07 KB, patch)
2011-03-29 19:45 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
Patch (14.71 KB, patch)
2011-03-30 10:52 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
Patch (14.80 KB, patch)
2011-03-30 13:04 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-03-29 19:45:02 PDT
Created attachment 87454 [details] Patch
Dominic Cooney
Comment 2 2011-03-29 19:46:39 PDT
Comment on attachment 87454 [details] Patch This does a drive-by on keygen.html to exercise the new DRT functionality. Thoughts? (OK? Don’t bother? Separate test?)
Collabora GTK+ EWS bot
Comment 3 2011-03-29 21:36:27 PDT
Attachment 87454 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8285609
Dominic Cooney
Comment 4 2011-03-29 22:58:56 PDT
Comment on attachment 87454 [details] Patch Oops—broke GTK. I will have another go at this.
Dominic Cooney
Comment 5 2011-03-30 10:52:36 PDT
Created attachment 87573 [details] Patch
Dominic Cooney
Comment 6 2011-03-30 13:04:55 PDT
Created attachment 87601 [details] Patch
Dimitri Glazkov (Google)
Comment 7 2011-03-30 16:26:33 PDT
Comment on attachment 87601 [details] Patch yay us. Let's go.
WebKit Commit Bot
Comment 8 2011-03-30 19:34:02 PDT
Comment on attachment 87601 [details] Patch Clearing flags on attachment: 87601 Committed r82536: <http://trac.webkit.org/changeset/82536>
WebKit Commit Bot
Comment 9 2011-03-30 19:34:08 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2011-03-30 20:35:56 PDT
http://trac.webkit.org/changeset/82536 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.