Bug 57087

Summary: [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
Product: WebKit Reporter: Kristian Amlie <kristian.amlie>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: abarth, benjamin, commit-queue, eric, kenneth, kling, ossy, webkit.review.bot
Priority: P3 Keywords: EasyFix, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 57016    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Kristian Amlie
Reported 2011-03-25 00:18:20 PDT
In Source/WebKit/qt/QtWebKit.pro there is a line "DEFINES -= QT_ASCII_CAST_WARNINGS", which disables warnings when you convert from anything 8-bit to a UTF-16 string (default QString). Since warnings are treated as errors in WebKit, this causes the build to fail. Ideally, WebKit should be able to compile with these warnings turned on.
Attachments
Patch (5.05 KB, patch)
2011-03-25 09:28 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (8.24 KB, patch)
2011-03-25 09:48 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (15.40 KB, patch)
2011-03-25 10:38 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (2.37 KB, patch)
2011-03-27 11:40 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (5.79 KB, patch)
2011-03-27 11:47 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kristian Amlie
Comment 1 2011-03-25 00:18:51 PDT
Related to https://bugs.webkit.org/show_bug.cgi?id=57016.
Benjamin Poulain
Comment 2 2011-03-25 09:28:57 PDT
Created attachment 86951 [details] Patch
Benjamin Poulain
Comment 3 2011-03-25 09:48:36 PDT
Created attachment 86952 [details] Patch
Andreas Kling
Comment 4 2011-03-25 10:12:11 PDT
Comment on attachment 86951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86951&action=review > Source/WebCore/ChangeLog:8 > + Use explicit convertion for string to avoid depending on the default codec s/convertion/conversion/
Andreas Kling
Comment 5 2011-03-25 10:15:02 PDT
Comment on attachment 86952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86952&action=review > Source/WebKit2/ChangeLog:8 > + Use explicit convertion for string to avoid depending on the default codec s/convertion/conversion/
Benjamin Poulain
Comment 6 2011-03-25 10:23:23 PDT
Comment on attachment 86951 [details] Patch Landed as r81967.
Benjamin Poulain
Comment 7 2011-03-25 10:26:09 PDT
Comment on attachment 86952 [details] Patch Landed: r81968
Benjamin Poulain
Comment 8 2011-03-25 10:38:28 PDT
Created attachment 86957 [details] Patch
Benjamin Poulain
Comment 9 2011-03-25 10:39:10 PDT
I'll finish the tests later, the diff is already huge and I need to find a way to automate some of the conversions.
Andreas Kling
Comment 10 2011-03-26 11:23:23 PDT
Comment on attachment 86957 [details] Patch Did you performance test this on AIX?
WebKit Commit Bot
Comment 11 2011-03-27 00:19:15 PDT
Comment on attachment 86957 [details] Patch Clearing flags on attachment: 86957 Committed r82059: <http://trac.webkit.org/changeset/82059>
WebKit Commit Bot
Comment 12 2011-03-27 00:19:19 PDT
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 13 2011-03-27 03:51:28 PDT
Reopening, there is still the define to change.
Benjamin Poulain
Comment 14 2011-03-27 11:40:50 PDT
Created attachment 87079 [details] Patch
Benjamin Poulain
Comment 15 2011-03-27 11:47:39 PDT
Created attachment 87082 [details] Patch Hopefully it is the last patch. This enable QT_ASCII_CAST_WARNINGS by default and disable it where the warning does not make sense.
Andreas Kling
Comment 16 2011-03-27 11:53:28 PDT
Comment on attachment 87082 [details] Patch Good luck, monsieur Poulain!
WebKit Commit Bot
Comment 17 2011-03-27 15:51:59 PDT
The commit-queue encountered the following flaky tests while processing attachment 87079 [details]: fast/forms/input-appearance-preventDefault.html bug 57194 (author: adele@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 18 2011-03-27 15:55:20 PDT
Comment on attachment 87079 [details] Patch Clearing flags on attachment: 87079 Committed r82082: <http://trac.webkit.org/changeset/82082>
Benjamin Poulain
Comment 19 2011-03-28 03:21:56 PDT
Comment on attachment 87082 [details] Patch I cq+ this one and I'll check the bots to see if I break any platform.
WebKit Commit Bot
Comment 20 2011-03-28 09:29:30 PDT
Comment on attachment 87082 [details] Patch Clearing flags on attachment: 87082 Committed r82125: <http://trac.webkit.org/changeset/82125>
WebKit Commit Bot
Comment 21 2011-03-28 09:29:34 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 22 2011-03-28 10:53:05 PDT
Buildfix landed in http://trac.webkit.org/changeset/82134. Unfortunately CQ can't test define changes in project files due to: https://bugs.webkit.org/show_bug.cgi?id=38054
WebKit Review Bot
Comment 23 2011-03-28 12:00:42 PDT
http://trac.webkit.org/changeset/82134 might have broken Leopard Intel Release (Tests)
Csaba Osztrogonác
Comment 24 2011-03-28 14:24:01 PDT
(In reply to comment #18) > (From update of attachment 87079 [details]) > Clearing flags on attachment: 87079 > > Committed r82082: <http://trac.webkit.org/changeset/82082> Typo fix for it landed in http://trac.webkit.org/changeset/82155
Note You need to log in before you can comment on or make changes to this bug.