Bug 56881

Summary: Teach update-webkit about gyp
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2011-03-22 16:56:51 PDT
Teach update-webkit about gyp
Attachments
Patch (4.96 KB, patch)
2011-03-22 17:02 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-03-22 17:02:32 PDT
Created attachment 86547 [details] Patch
Adam Barth
Comment 2 2011-03-22 17:03:42 PDT
Comment on attachment 86547 [details] Patch ok.
Adam Barth
Comment 3 2011-03-22 18:08:19 PDT
Comment on attachment 86547 [details] Patch Clearing flags on attachment: 86547 Committed r81735: <http://trac.webkit.org/changeset/81735>
Adam Barth
Comment 4 2011-03-22 18:08:23 PDT
All reviewed patches have been landed. Closing bug.
Mark Rowe (bdash)
Comment 5 2011-03-22 18:47:03 PDT
Comment on attachment 86547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86547&action=review > Tools/Scripts/generate-project-files:37 > +# This allows building from Source without a copy of Tools (as Apple's internal builds do). Note that this doesn’t help our builds at all since the builds in question check out using “svn export”, not using any WebKit scripts.
Mark Rowe (bdash)
Comment 6 2011-03-22 18:48:05 PDT
In other words, that part of the comment is misleading as-is so I’m not sure why it’s present.
Adam Barth
Comment 7 2011-03-22 18:52:31 PDT
(In reply to comment #5) > (From update of attachment 86547 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86547&action=review > > > Tools/Scripts/generate-project-files:37 > > +# This allows building from Source without a copy of Tools (as Apple's internal builds do). > > Note that this doesn’t help our builds at all since the builds in question check out using “svn export”, not using any WebKit scripts. > > In other words, that part of the comment is misleading as-is so I’m not sure why it’s present. You obviously know more about the Apple internal build system than I do. The comment is meant to explain that we have two scripts in order to make Source buildable without Tools. As an example of such a situation, Tools is not an input into Apple's internal build system. We can certainly update the comment to explain this more clearly.
Note You need to log in before you can comment on or make changes to this bug.