Bug 56726

Summary: [EFL] Add sound / mute button to MediaControl UI
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, leandro, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 55463    
Bug Blocks:    
Attachments:
Description Flags
Proposed Patch
none
Modified Patch none

Gyuyoung Kim
Reported 2011-03-20 17:38:03 PDT
Add sound / mute button.
Attachments
Proposed Patch (12.03 KB, patch)
2011-03-20 18:08 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Modified Patch (10.28 KB, patch)
2011-03-24 06:15 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-03-20 18:08:58 PDT
Created attachment 86287 [details] Proposed Patch
Lucas De Marchi
Comment 2 2011-03-23 14:12:00 PDT
Comment on attachment 86287 [details] Proposed Patch The same problem as in bug 55463. Please, merge these in only 1 widget. Later on you might want to add more states indicating the volume level.
Gyuyoung Kim
Comment 3 2011-03-23 16:09:49 PDT
Yes, I also do that. I am going to upload new patch.
Gyuyoung Kim
Comment 4 2011-03-24 06:15:34 PDT
Created attachment 86763 [details] Modified Patch I modify this patch based on play button implementation. BTW, I'd like to volume control later.
Gyuyoung Kim
Comment 5 2011-03-24 06:15:58 PDT
(In reply to comment #4) > Created an attachment (id=86763) [details] > Modified Patch > > I modify this patch based on play button implementation. BTW, I'd like to add volume control later.
Lucas De Marchi
Comment 6 2011-03-24 16:57:52 PDT
Comment on attachment 86763 [details] Modified Patch LGTM
WebKit Commit Bot
Comment 7 2011-03-24 23:53:37 PDT
The commit-queue encountered the following flaky tests while processing attachment 86763 [details]: inspector/debugger/debugger-expand-scope.html bug 57086 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2011-03-24 23:57:18 PDT
Comment on attachment 86763 [details] Modified Patch Clearing flags on attachment: 86763 Committed r81944: <http://trac.webkit.org/changeset/81944>
WebKit Commit Bot
Comment 9 2011-03-24 23:57:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.