Bug 56473

Summary: Add play state callbacks to MediaControls, kill timeUpdate timer.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 56489    
Bug Blocks: 53020    
Attachments:
Description Flags
Patch eric.carlson: review+

Dimitri Glazkov (Google)
Reported 2011-03-16 11:16:25 PDT
Add play state callbacks to MediaControls, kill timeUpdate timer.
Attachments
Patch (6.19 KB, patch)
2011-03-16 11:18 PDT, Dimitri Glazkov (Google) 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-03-16 11:18:51 PDT
Created attachment 85944 [details] Patch
Eric Carlson
Comment 2 2011-03-16 11:22:35 PDT
Comment on attachment 85944 [details] Patch Nice!
Dimitri Glazkov (Google)
Comment 3 2011-03-16 11:56:06 PDT
(In reply to comment #2) > (From update of attachment 85944 [details]) > Nice! Since this change does an extra update of the timeline/status as soon as we start playing, the status values are more accurate. However, this affects results in media/controls-without-preload.html, because canplaythrough event is fired asynchronously. By the time it's fired, we already started playing and the status is slightly different. Should I: a) change expectations for the test b) remove updating on start?
Dimitri Glazkov (Google)
Comment 4 2011-03-16 14:52:21 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 85944 [details] [details]) > > Nice! > > Since this change does an extra update of the timeline/status as soon as we start playing, the status values are more accurate. However, this affects results in media/controls-without-preload.html, because canplaythrough event is fired asynchronously. By the time it's fired, we already started playing and the status is slightly different. > > Should I: > a) change expectations for the test > b) remove updating on start? I ended up improving the test in http://trac.webkit.org/changeset/81280.
Dimitri Glazkov (Google)
Comment 5 2011-03-16 15:16:01 PDT
Committed r81283: <http://trac.webkit.org/changeset/81283>
Note You need to log in before you can comment on or make changes to this bug.