Bug 56430

Summary: WebCore GYP build should build platform/
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-03-15 17:09:18 PDT
WebCore GYP build should build platform/
Attachments
Patch (13.68 KB, patch)
2011-03-15 17:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (11.98 KB, patch)
2011-03-15 23:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-15 17:11:13 PDT
Created attachment 85880 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-15 17:42:10 PDT
Comment on attachment 85880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85880&action=review > Source/WebCore/dom/ContainerNode.cpp:168 > notifyChildInserted(child); > + if (!child->inDocument()) > + break; Um... wrong change?
Adam Barth
Comment 3 2011-03-15 22:42:00 PDT
Comment on attachment 85880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85880&action=review >> Source/WebCore/dom/ContainerNode.cpp:168 >> + if (!child->inDocument()) >> + break; > > Um... wrong change? Oops! Indeed.
Adam Barth
Comment 4 2011-03-15 23:18:04 PDT
Created attachment 85912 [details] Patch
WebKit Commit Bot
Comment 5 2011-03-16 01:58:47 PDT
Comment on attachment 85912 [details] Patch Clearing flags on attachment: 85912 Committed r81230: <http://trac.webkit.org/changeset/81230>
WebKit Commit Bot
Comment 6 2011-03-16 01:58:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.