Bug 56296

Summary: Clean up includes/forward declarations in IconDatabaseBase
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 52451    
Attachments:
Description Flags
Patch v1
beidson: commit-queue-
Patch v2 - Left out the WebKit pieces
sam: review-, beidson: commit-queue-
Patch v3 sam: review+, beidson: commit-queue-

Brady Eidson
Reported 2011-03-14 01:47:25 PDT
Clean up includes/forward declarations in IconDatabaseBase It'd be great to get rid of the "PlatformString.h" include.
Attachments
Patch v1 (4.78 KB, patch)
2011-03-14 01:49 PDT, Brady Eidson 		beidson: commit-queue-
DetailsFormatted DiffDiff
Patch v2 - Left out the WebKit pieces (5.19 KB, patch)
2011-03-14 10:01 PDT, Brady Eidson 		sam: review-
beidson: commit-queue-
DetailsFormatted DiffDiff
Patch v3 (3.93 KB, patch)
2011-03-14 10:15 PDT, Brady Eidson 		sam: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2011-03-14 01:49:51 PDT
Created attachment 85657 [details] Patch v1
WebKit Review Bot
Comment 2 2011-03-14 01:51:03 PDT
Attachment 85657 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/loader/icon/IconDatabaseBase.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2011-03-14 10:01:45 PDT
Created attachment 85686 [details] Patch v2 - Left out the WebKit pieces
Brady Eidson
Comment 4 2011-03-14 10:02:28 PDT
Ignore the "Left out the WebKit pieces" in the patch title - autocomplete, damn you!
Sam Weinig
Comment 5 2011-03-14 10:06:02 PDT
Comment on attachment 85686 [details] Patch v2 - Left out the WebKit pieces View in context: https://bugs.webkit.org/attachment.cgi?id=85686&action=review > Source/WebCore/loader/icon/IconDatabase.h:31 > +#include "PlatformString.h" This should be <wtf/text/WTFString.h> > Source/WebCore/loader/icon/IconDatabaseBase.h:34 > +namespace WTF { > +class String; > +} This should use <wtf/Forward.h> > Source/WebCore/loader/icon/IconDatabaseBase.h:97 > + virtual WTF::String databasePath() const; If you use forward.h, the WTF is not necessary.
Brady Eidson
Comment 6 2011-03-14 10:15:41 PDT
Created attachment 85688 [details] Patch v3
Note You need to log in before you can comment on or make changes to this bug.