Bug 56207

Summary: Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch abarth: review+

Dimitri Glazkov (Google)
Reported 2011-03-11 11:05:54 PST
Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
Attachments
Patch (3.79 KB, patch)
2011-03-11 11:08 PST, Dimitri Glazkov (Google) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-03-11 11:08:18 PST
Created attachment 85497 [details] Patch
Adam Barth
Comment 2 2011-03-11 11:09:33 PST
Comment on attachment 85497 [details] Patch Thanks.
Dimitri Glazkov (Google)
Comment 3 2011-03-11 11:11:52 PST
Committed r80865: <http://trac.webkit.org/changeset/80865>
Eric Seidel (no email)
Comment 4 2011-03-11 11:13:16 PST
Comment on attachment 85497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85497&action=review > Source/JavaScriptCore/gyp/JavaScriptCore.gyp:149 > + 'action_name': 'Generate DTrace Header', > + 'inputs': [], > + 'outputs': [], > + 'action': [ funny indent.
Eric Seidel (no email)
Comment 5 2011-03-11 11:13:41 PST
Comment on attachment 85497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85497&action=review > Source/JavaScriptCore/gyp/generate-dtrace-header.sh:4 > +TRACING_D="${SRCROOT}/runtime/Tracing.d"; > +TRACING_H="${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/TracingDtrace.h"; the ; are not needed. > Source/JavaScriptCore/gyp/generate-dtrace-header.sh:8 > +fi; I don't think the ; i sneeded.
Note You need to log in before you can comment on or make changes to this bug.