Bug 56135

Summary: VisiblePosition's next and previous should take an enum instead of a boolean
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: darin, eric, leviw, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 53409    
Attachments:
Description Flags
cleanup tony: review+

Ryosuke Niwa
Reported 2011-03-10 12:50:49 PST
There many places where we call next(true) and previous(true) and it's totally unclear what it means.
Attachments
cleanup (25.03 KB, patch)
2011-03-10 13:08 PST, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-03-10 13:08:47 PST
Created attachment 85381 [details] cleanup
Ryosuke Niwa
Comment 2 2011-03-10 13:16:02 PST
Committed r80752: <http://trac.webkit.org/changeset/80752>
Ryosuke Niwa
Comment 3 2011-03-10 14:46:58 PST
I accidentally reversed the boolean logic in the original patch. Fixed it in http://trac.webkit.org/changeset/80766.
Note You need to log in before you can comment on or make changes to this bug.