Bug 56049

Summary: Fix some potentially flaky tests
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: REOPENED    
Severity: Normal CC: abarth, mihaip, wangxianzhu
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 54355    
Attachments:
Description Flags
Patch
none
Patch none

Tony Gentilcore
Reported 2011-03-09 13:41:33 PST
Fix some potentially flaky tests
Attachments
Patch (5.85 KB, patch)
2011-03-09 13:45 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch (5.87 KB, patch)
2011-03-09 16:08 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2011-03-09 13:45:45 PST
Created attachment 85225 [details] Patch
Mihai Parparita
Comment 2 2011-03-09 14:56:59 PST
Comment on attachment 85225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85225&action=review > LayoutTests/media/video-src-plus-source.html:8 > }); I think you need the final "true" argument to addEventListener so that this handler is registered in the capture phase. Before you call findMediaElement(), mediaElement is set to document, and the loadedmetadata event doesn't bubble.
Tony Gentilcore
Comment 3 2011-03-09 16:08:02 PST
Created attachment 85252 [details] Patch
Tony Gentilcore
Comment 4 2011-03-09 16:08:28 PST
> I think you need the final "true" argument to addEventListener so that this handler is registered in the capture phase. Before you call findMediaElement(), mediaElement is set to document, and the loadedmetadata event doesn't bubble. Nice catch! That would have broken the ability for the test to fail in that way. Fixed now.
Tony Gentilcore
Comment 5 2011-03-09 16:16:17 PST
Comment on attachment 85252 [details] Patch Clearing flags on attachment: 85252 Committed r80670: <http://trac.webkit.org/changeset/80670>
Tony Gentilcore
Comment 6 2011-03-09 16:16:20 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 7 2011-03-10 01:02:56 PST
This patch seems to have broken platform/mac/accessibility/aria-expanded-notifications.html. I'm going to revert the change to that test.
Adam Barth
Comment 8 2011-03-10 01:12:05 PST
Partial revert in http://trac.webkit.org/changeset/80697
Note You need to log in before you can comment on or make changes to this bug.