Bug 55950

Summary:

addInlineStyleIfNeeded should take EditingStyle

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

49956

Attachments:

Description	Flags
cleanup	darin: review+

Ryosuke Niwa

Reported 2011-03-08 11:09:15 PST

This is a cleanup.

Attachments
cleanup (11.07 KB, patch) 2011-03-08 11:36 PST, Ryosuke Niwa	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2011-03-08 11:36:29 PST

Created attachment 85068 [details] cleanup

Darin Adler

Comment 2 2011-03-08 11:44:49 PST

Comment on attachment 85068 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=85068&action=review > Source/WebCore/editing/ApplyStyleCommand.cpp:79 > - explicit StyleChange(CSSStyleDeclaration*, const Position&); > + explicit StyleChange(EditingStyle*, const Position&); It doesn’t make any sense to use the explicit keyword on a constructor that can’t be called with a single argument. So “explicit” should be removed here.

Ryosuke Niwa

Comment 3 2011-03-08 11:57:56 PST

(In reply to comment #2) > (From update of attachment 85068 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85068&action=review > > > Source/WebCore/editing/ApplyStyleCommand.cpp:79 > > - explicit StyleChange(CSSStyleDeclaration*, const Position&); > > + explicit StyleChange(EditingStyle*, const Position&); > > It doesn’t make any sense to use the explicit keyword on a constructor that can’t be called with a single argument. So “explicit” should be removed here. That's what I thought. Okay, I'm getting rid of that. Thanks for the review.

Ryosuke Niwa

Comment 4 2011-03-08 12:45:50 PST

Landed as http://trac.webkit.org/changeset/80580.

Note You need to log in before you can comment on or make changes to this bug.