Bug 5567
| Summary: | Use the theme font instead of "Lucida Grande" for buttons | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Rosyna <webkit-bugs> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bugzilla.opendarwin, ian |
| Priority: | P3 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| URL: | http://www.bankone.com/bank | ||
| Bug Depends on: | 3303 | ||
| Bug Blocks: | |||
Rosyna
WebKit/khtml/css/html4.css hard codes Lucida Grande as the theme font for form controls rather than
properly asking the system for the theme font. This makes it look out of whack if the user changes the
theme font. This can be tested with the following command in the terminal (/Applications/Utilities/
Terminal):
defaults write com.apple.Safari NSSystemFont ComicSansMS
alternatively
defaults write com.apple.Safari NSSystemFont Bauhaus93
or
defaults write com.apple.Safari NSSystemFont Copperplate
Depending on how ugly you want the result to be.
Hardcoding the theme font is bad.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Joost de Valk (AlthA)
Reassigning to webkit-unassigned, to make sure more people see this.
Joost de Valk (AlthA)
Seems very valid. This is an enhancement though, not a bug.
Sören Kuklau
> This is an enhancement though, not a bug.
Is it? I'd be surprised if Apple doesn't have a guideline somewhere not to hardcode fonts when there's no real need to. In which case it would be a bug.
Alexey Proskuryakov
I don't see this problem at the provided URL. However, I do see it on some Bugzilla pages, such as <http://bugzilla.opendarwin.org/attachment.cgi?id=6473&action=edit>.
I think that some localizations use something other than 11px (?!) Lucida Grande as a system font; this bug would be more important for those.
Based on the comment in html4.css, I'm setting this as dependent on bug 3303. And I also think that this is a bug, not an enchancement request.
Dave Hyatt
Fixed.
David Kilzer (:ddkilzer)
r15888 with layout tests in r15889