Bug 55468

Summary: New .png files added by commit-queue bots are not marked as binary
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: abarth, alancutter, cbiesinger, eric, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 107724    
Bug Blocks:    

Adam Roben (:aroben)
Reported 2011-03-01 07:37:08 PST
Whenever the commit-queue commits a patch that adds new .png files, the .pngs aren't marked as binary. The effect of this most noticeable to me is that the webkit-changes email generated for these patches includes a bunch of PNG-as-ASCII junk which significantly bloats the email.
Attachments
Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-03-01 07:38:09 PST
One way to fix this would be to turn on Subversion auto-props on the commit-queue bots. To do that, you just need to uncomment the following lines in ~/.subversion/config enable-auto-props = yes ...and later... *.png = svn:mime-type=image/png
Adam Roben (:aroben)
Comment 2 2011-03-01 07:38:42 PST
Note that auto-props are respected even when committing via git-svn.
Eric Seidel (no email)
Comment 3 2011-03-01 09:45:01 PST
Very easy to do. (Especially if there is a svn config command to do that.)
Eric Seidel (no email)
Comment 4 2011-03-01 09:48:04 PST
I suspect we should create the perfect config file for the commit-queue, and then copy it into the svn repository. Then the commit bots can either install it automatically, or use --config-dir. It doesn't appear that svn has a "config" command like git does for editing its config files.
Eric Seidel (no email)
Comment 5 2011-03-01 09:49:14 PST
Basically if someone tells me exactly what commands to run on the bots, I'm happy to make that happen. Even better would be pointing towards the exact desired config file, which I'm happy to make sure all of the bots use.
Adam Roben (:aroben)
Comment 6 2011-03-01 10:15:12 PST
I think putting this in ~/.subversion/config will do what we want (and nothing more): [miscellany] enable-auto-props = yes [auto-props] *.png = svn:mime-type=image/png
Alan Cutter
Comment 7 2013-02-28 15:44:50 PST
bug 107724 addresses this issue and has a patch to amend future bots, pending a cq+.
Note You need to log in before you can comment on or make changes to this bug.