Bug 55355

Summary: TextIterator should not be a friend of RenderTextControl
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, dominicc, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54179    
Attachments:
Description Flags
Patch none

Roland Steiner
Reported 2011-02-28 00:13:08 PST
TextIterator should use interface methods rather than being a friend.
Attachments
Patch (1.67 KB, patch)
2011-02-28 00:18 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-02-28 00:18:31 PST
Created attachment 84024 [details] Patch Simple patch: remove need for friend-clause by making innerTextElement() public. Even after the general new-shadow-DOM refactoring there will be a common inner text element, so the accessor will likely stay around. We might want to restrict visibility of the shadow DOM from RenderTextControl, but this is for yet another (larger) refactoring.
Kent Tamura
Comment 2 2011-02-28 00:23:10 PST
Comment on attachment 84024 [details] Patch looks good.
WebKit Commit Bot
Comment 3 2011-02-28 00:45:40 PST
Comment on attachment 84024 [details] Patch Clearing flags on attachment: 84024 Committed r79845: <http://trac.webkit.org/changeset/79845>
WebKit Commit Bot
Comment 4 2011-02-28 00:45:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.