Bug 55065

Summary: Setting shadow host should also attach and set inDocument, just like appending/inserting a child.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 53020    
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2011-02-23 11:17:37 PST
Setting shadow host should also attach and set inDocument, just like appending/inserting a child.
Attachments
Patch (1.41 KB, patch)
2011-02-23 11:19 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-02-23 11:19:38 PST
Created attachment 83507 [details] Patch
Darin Adler
Comment 2 2011-02-23 11:22:49 PST
Comment on attachment 83507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83507&action=review > Source/WebCore/dom/Element.cpp:1143 > + if (inDocument()) > + newRoot->insertedIntoDocument(); Is there a case where newRoot was already in a document?
Dimitri Glazkov (Google)
Comment 3 2011-02-23 11:25:15 PST
(In reply to comment #2) > (From update of attachment 83507 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83507&action=review > > > Source/WebCore/dom/Element.cpp:1143 > > + if (inDocument()) > > + newRoot->insertedIntoDocument(); > > Is there a case where newRoot was already in a document? Not currently, but we will have to defend against this once script is allowed to set shadowHost. I have a FIXME at the top of the method to not forget.
WebKit Commit Bot
Comment 4 2011-02-23 12:07:05 PST
Comment on attachment 83507 [details] Patch Clearing flags on attachment: 83507 Committed r79468: <http://trac.webkit.org/changeset/79468>
WebKit Commit Bot
Comment 5 2011-02-23 12:07:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.