Bug 54977

Summary: [Qt] [Symbian] build system fixes
Product: WebKit Reporter: Siddharth Mathur <s.mathur>
Component: PlatformAssignee: Siddharth Mathur <s.mathur>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, laszlo.gombos, ossy, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 50251    
Attachments:
Description Flags
fix symbian build break none

Siddharth Mathur
Reported 2011-02-22 11:36:12 PST
- After recent .pro and .pri refactoring, correct the way WebCore static library is linked. Affects Symbian and Windows primarily. - Also fix UID3s for WebKit2 on Symbian
Attachments
fix symbian build break (1.04 KB, patch)
2011-04-04 14:52 PDT, jade han 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2011-03-07 06:23:50 PST
Fix for UID3 for WebKit2 for Symbian are landed as http://trac.webkit.org/changeset/79446. Keep the bug open as more fixes are needed.
jade han
Comment 2 2011-04-04 14:52:51 PDT
Created attachment 88136 [details] fix symbian build break
Csaba Osztrogonác
Comment 3 2011-04-04 15:24:16 PDT
Comment on attachment 88136 [details] fix symbian build break LGTM, r=me to go ahead. But we usually don't upload independent patches to a same bug report. :S You don't need to upload to bugzilla this kind of simple buildfixes, just ask a reviewer or a committer on #qtwebkit or #webkit to land it manually. ;)
Csaba Osztrogonác
Comment 4 2011-04-04 15:34:14 PDT
Comment on attachment 88136 [details] fix symbian build break Landed in http://trac.webkit.org/changeset/82883
WebKit Review Bot
Comment 5 2011-04-04 17:10:42 PDT
http://trac.webkit.org/changeset/82883 might have broken Windows XP Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.