Bug 54933

Summary: Make Editor::selectionComputedStyle return EditingStyle
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: darin, enrica, eric, ojan, tkent, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54932    
Attachments:
Description Flags
cleanup darin: review+

Ryosuke Niwa
Reported 2011-02-21 20:44:48 PST
This is a cleanup.
Attachments
cleanup (16.62 KB, patch)
2011-02-21 20:56 PST, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-02-21 20:56:43 PST
Created attachment 83262 [details] cleanup
Darin Adler
Comment 2 2011-02-22 12:02:04 PST
Comment on attachment 83262 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=83262&action=review > Source/WebCore/ChangeLog:9 > + Renamed selectionComputedStyle to selectionStartComputedStyle and changed the return type to EditingStyle. > + It also no longer takes a boolean shouldUseFixedFontDefaultSize. I’m not sure this function needs the word computed in it any more. When the function returned a CSS style object, then it needed computed in its name because of how the same data structure is used for actual computed style and other style purposes. I think maybe selectionStartStyle would be a suitable name.
Ryosuke Niwa
Comment 3 2011-02-22 18:55:49 PST
Comment on attachment 83262 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=83262&action=review >> Source/WebCore/ChangeLog:9 >> + It also no longer takes a boolean shouldUseFixedFontDefaultSize. > > I’m not sure this function needs the word computed in it any more. When the function returned a CSS style object, then it needed computed in its name because of how the same data structure is used for actual computed style and other style purposes. I think maybe selectionStartStyle would be a suitable name. Sounds good to me. Will rename before landing. Thanks for the reviews!
Ryosuke Niwa
Comment 4 2011-02-22 21:35:59 PST
Committed r79398: <http://trac.webkit.org/changeset/79398>
Note You need to log in before you can comment on or make changes to this bug.