Bug 54545

Summary: DragController should use Color::serialized() when passing colors to CSSStyleDeclaration
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54539    
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2011-02-16 03:50:59 PST
DragController::concludeEditDrag() currently passes the string returned by Color::nameForRenderTreeAsText() to CSSStyleDeclaration::setProperty(). If the color has an alpha value, the string will be in #RRGGBBAA format which is not valid CSS.
Attachments
Proposed patch (1.45 KB, patch)
2011-02-16 03:53 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-02-16 03:53:44 PST
Created attachment 82612 [details] Proposed patch
Andreas Kling
Comment 2 2011-02-19 19:10:43 PST
Comment on attachment 82612 [details] Proposed patch Clearing flags on attachment: 82612 Committed r79145: <http://trac.webkit.org/changeset/79145>
Andreas Kling
Comment 3 2011-02-19 19:10:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.