Bug 54540

Summary: Editing styles should not emit #RRGGBBAA colors
Product: WebKit Reporter: Andreas Kling <kling>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54539    
Attachments:
Description Flags
Proposed patch rniwa: review+

Andreas Kling
Reported 2011-02-16 03:05:45 PST
The StyleChange::fontColor() is currently created from Color::nameForRenderTreeAsText() which is incorrect as these colors may be exposed to the web.
Attachments
Proposed patch (12.46 KB, patch)
2011-02-16 03:10 PST, Andreas Kling 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-02-16 03:10:32 PST
Created attachment 82608 [details] Proposed patch
Ryosuke Niwa
Comment 2 2011-02-16 17:35:48 PST
Comment on attachment 82608 [details] Proposed patch We definitely need a test for this.
Ryosuke Niwa
Comment 3 2011-02-16 17:54:37 PST
Comment on attachment 82608 [details] Proposed patch Oops, I didn't see the additional test case in inline-style-container.js. I take back my r- and r+ it. Please rephrase the change log entry to mention the test case is added to inline-style-container.js.
Ryosuke Niwa
Comment 4 2011-02-16 17:55:12 PST
Note that Firefox 3.6 also emits lowercase color code so new behavior shouldn't break most of websites.
Andreas Kling
Comment 5 2011-02-16 18:55:27 PST
Committed r78773: <http://trac.webkit.org/changeset/78773>
Note You need to log in before you can comment on or make changes to this bug.