Bug 53437

Summary: Convert editing/deleting/5168598.html to dumpAsText test
Product: WebKit Reporter: Chang Shu <cshu>
Component: HTML EditingAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, suresh.voruganti
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 53031    
Attachments:
Description Flags
fix patch
rniwa: review-
fix patch 2 none

Chang Shu
Reported 2011-01-31 10:18:39 PST
The intention of the test case is to check the existence of a link node and it should not crash. This can be done by text-only results, which is cross-platform.
Attachments
fix patch (10.94 KB, patch)
2011-01-31 10:25 PST, Chang Shu 		rniwa: review-
DetailsFormatted DiffDiff
fix patch 2 (10.92 KB, patch)
2011-01-31 11:20 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-01-31 10:25:05 PST
Created attachment 80656 [details] fix patch
Ryosuke Niwa
Comment 2 2011-01-31 11:10:28 PST
Comment on attachment 80656 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=80656&action=review > LayoutTests/ChangeLog:5 > + Convert the test case to text-only so the expected result is cross-platform. Please explicitly say we're converting this to a dumpAsText test. > LayoutTests/editing/deleting/5168598.html:1 > <body> Can we add <!DOCTYPE html>? > LayoutTests/editing/deleting/5168598.html:4 > +<div id="console"></div> We won't need this if we make the following changes. > LayoutTests/editing/deleting/5168598.html:14 > +function log(message) { > + var console = document.getElementById("console"); > + var text = document.createTextNode(message); > + console.appendChild(text); > +} I'm not sure if it makes sense to add this log function just to print one line. > LayoutTests/editing/deleting/5168598.html:21 > +log(document.getElementsByTagName('a').item(0) + "\n"); I would have done: var numberOfElements = document.getElementsByTagName('a').length; document.write(numberOfElements ? 'FAIL: there were ' + numberOfElements + ' anchor elements but expected none' : 'PASS');
Chang Shu
Comment 3 2011-01-31 11:20:02 PST
Created attachment 80663 [details] fix patch 2
Ryosuke Niwa
Comment 4 2011-01-31 11:22:51 PST
Comment on attachment 80663 [details] fix patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=80663&action=review r+ but you might want to consider hiding input element after printing PASS/FAIL. > LayoutTests/editing/deleting/5168598-expected.txt:3 > + PASS I think the whitespace before PASS will go away if you hid the input element after the test.
Chang Shu
Comment 5 2011-01-31 12:55:07 PST
Comment on attachment 80663 [details] fix patch 2 Committed r77154: <http://trac.webkit.org/changeset/77154>
Chang Shu
Comment 6 2011-01-31 12:56:13 PST
All reviewed patches have been landed. Closing bug.
Suresh Voruganti
Comment 7 2011-02-10 13:06:30 PST
Removing from Qtwebkit 2.1.1 Nice to have master bug.
Note You need to log in before you can comment on or make changes to this bug.