Bug 53314

Summary: REGRESSION(r76951): Appearance of media controls changed slightly on Qt/Chromium ports
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: DOMAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ossy, scherkus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 53122, 53674    
Bug Blocks: 53020    
Attachments:
Description Flags
Patch jamesr: review+

Dimitri Glazkov (Google)
Reported 2011-01-28 11:03:03 PST
This is due to the fact that UA stylesheets are now matched inside of the shadow DOM subtree. The fix is to tweak the stylesheets to get the back to the same shape. Qt test: media/controls-without-preload.html -> failed Chromium tests: media/controls-strict.html = IMAGE+TEXT media/video-zoom-controls.html = IMAGE+TEXT
Attachments
Patch (1.45 KB, patch)
2011-01-31 15:49 PST, Dimitri Glazkov (Google) 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-01-28 12:18:15 PST
http://trac.webkit.org/changeset/76957 might have broken Leopard Intel Release (Tests)
Dimitri Glazkov (Google)
Comment 2 2011-01-31 15:49:40 PST
Created attachment 80692 [details] Patch
James Robinson
Comment 3 2011-01-31 15:52:05 PST
Comment on attachment 80692 [details] Patch ok
Dimitri Glazkov (Google)
Comment 4 2011-01-31 15:54:58 PST
Committed r77171: <http://trac.webkit.org/changeset/77171>
Dimitri Glazkov (Google)
Comment 5 2011-02-03 09:06:43 PST
*** Bug 53674 has been marked as a duplicate of this bug. ***
Dimitri Glazkov (Google)
Comment 6 2011-02-03 09:07:16 PST
Qt still isn't fixed.
Note You need to log in before you can comment on or make changes to this bug.