Bug 53264

Summary: [GTK] Implement device element dialog and stream device probing
Product: WebKit Reporter: Adam Bergkvist <adam.bergkvist>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cgarcia, eric, joone, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 47264    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch
none
Updated patch none

Adam Bergkvist
Reported 2011-01-27 16:01:00 PST
Some GTK specific parts are needed to use the device element (device selector dialog and stream device probing).
Attachments
Proposed patch (22.39 KB, patch)
2011-01-27 20:45 PST, Adam Bergkvist 		no flags
DetailsFormatted DiffDiff
Updated patch (23.09 KB, patch)
2011-02-03 11:12 PST, Adam Bergkvist 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Bergkvist
Comment 1 2011-01-27 20:45:41 PST
Created attachment 80414 [details] Proposed patch Proposed GTK implementation of the platform specific parts of the device element (see https://bugs.webkit.org/show_bug.cgi?id=47264).
Philippe Normand
Comment 2 2011-01-28 04:44:05 PST
Comment on attachment 80414 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=80414&action=review I haven't done a full review of this patch, only spotted this small issue > Source/WebCore/platform/device/gstreamer/StreamDeviceManagerPrivateGStreamer.cpp:79 > + const GParamSpec* pspec = gst_property_probe_get_property(probe, "device"); If think a if (pspec) test is missing here.
Philippe Normand
Comment 3 2011-01-28 04:48:10 PST
Comment on attachment 80414 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=80414&action=review oh, also this question :) > Source/WebCore/platform/device/gstreamer/StreamDeviceManagerPrivateGStreamer.cpp:43 > +#define GST_AUDIO_SRC_ELEMENT "alsasrc" what about using autoaudiosrc and autovideosrc ? The #if could be avoid in that case.
Adam Bergkvist
Comment 4 2011-01-28 08:50:14 PST
(In reply to comment #3) > what about using autoaudiosrc and autovideosrc ? The #if could be avoid in that case. Yes, that's something we should try
Adam Bergkvist
Comment 5 2011-02-03 11:12:11 PST
Created attachment 81091 [details] Updated patch Main reason for update is to match the patch on which this patch depends. Added null-check on pspec. We've done some experimenting with "auto-sources", but I haven't included it in this patch.
Adam Bergkvist
Comment 6 2011-04-15 06:28:46 PDT
Resolved as WONTFIX since the device element has been removed from the spec.
Eric Seidel (no email)
Comment 7 2011-04-18 09:10:15 PDT
Comment on attachment 81091 [details] Updated patch Cleared review? from attachment 81091 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.