Bug 53050

Summary: Remove RenderSlider::inDragMode and use SliderThumbElement::inDragMode instead.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED INVALID    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 44907    
Attachments:
Description Flags
Patch darin: review+

Dimitri Glazkov (Google)
Reported 2011-01-24 16:34:29 PST
Remove RenderSlider::inDragMode and use SliderThumbElement::inDragMode instead.
Attachments
Patch (9.96 KB, patch)
2011-01-24 16:36 PST, Dimitri Glazkov (Google) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-01-24 16:36:54 PST
Created attachment 79989 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-01-24 16:38:23 PST
Just cleaning stuff up after the move.
Darin Adler
Comment 3 2011-01-25 09:06:31 PST
Comment on attachment 79989 [details] Patch Seems strange to have all this code that is render tree oriented have to go back to the DOM tree for one thing and not the rest. The RenderThemeWin code especially stands out, with all those renderer checks mixed in with one DOM check.
Dimitri Glazkov (Google)
Comment 4 2011-01-25 14:19:08 PST
(In reply to comment #3) > (From update of attachment 79989 [details]) > Seems strange to have all this code that is render tree oriented have to go back to the DOM tree for one thing and not the rest. The RenderThemeWin code especially stands out, with all those renderer checks mixed in with one DOM check. I am on the fence with this patch. Perhaps turn this into a helper function on RenderSliderThumb object?
Dimitri Glazkov (Google)
Comment 5 2011-04-13 10:04:24 PDT
I decided that this patch isn't useful.
Note You need to log in before you can comment on or make changes to this bug.