Bug 52386
| Summary: | Map GC3Dboolean to bool instead of unsigned char in GraphicsContext3D | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zhenyao Mo <zmo> |
| Component: | WebGL | Assignee: | Zhenyao Mo <zmo> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | kbr |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | |||
| Bug Blocks: | 51908 | ||
Zhenyao Mo
As kbr pointed out in https://bugs.webkit.org/show_bug.cgi?id=51908, mapping it to unsigned char loses semantical information.
Instead of addressing this issue in https://bugs.webkit.org/show_bug.cgi?id=51908, I'd rather do it in a seperate patch before landing the reviewed patch in https://bugs.webkit.org/show_bug.cgi?id=51908.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Zhenyao Mo
Turns out it's just change the typedef of GC3Dboolean, because mapping bool to GLboolean in gl function calls won't raise any warnings, so I will fix this in the landing patch in 51908.