Bug 52308

Summary: show shared lines on both sides in code review tool
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, arv, commit-queue, eric, mihaip
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows none

Ojan Vafai
Reported 2011-01-12 10:43:49 PST
show shared lines on both sides in code review tool
Attachments
Patch (1.89 KB, patch)
2011-01-12 10:45 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows (12.02 KB, patch)
2011-01-27 18:42 PST, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-01-12 10:45:50 PST
Created attachment 78706 [details] Patch
WebKit Commit Bot
Comment 2 2011-01-12 14:56:08 PST
The commit-queue encountered the following flaky tests while processing attachment 78706 [details]: http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2011-01-12 14:58:52 PST
Comment on attachment 78706 [details] Patch Clearing flags on attachment: 78706 Committed r75642: <http://trac.webkit.org/changeset/75642>
WebKit Commit Bot
Comment 4 2011-01-12 14:58:57 PST
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 5 2011-01-27 18:42:14 PST
Created attachment 80397 [details] Change BinarySemaphore to wrap an auto-reset Win32 event on Windows
Adam Roben (:aroben)
Comment 6 2011-01-27 18:43:01 PST
Comment on attachment 80397 [details] Change BinarySemaphore to wrap an auto-reset Win32 event on Windows Whoops, wrong bug!
Note You need to log in before you can comment on or make changes to this bug.