Bug 52250

Summary: Stop instantiating legacy editing positions in ApplyBlockElementCommand and ApplyStyleCommand
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, eric, kalman, lweintraub, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 52099    
Attachments:
Description Flags
Patch
none
cleanup
none
don't generate bogus position like [br, 0] eric: review+

Ryosuke Niwa
Reported 2011-01-11 14:06:52 PST
This is a cleanup.
Attachments
Patch (14.62 KB, patch)
2011-01-11 14:09 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
cleanup (17.20 KB, patch)
2011-01-11 16:18 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
don't generate bogus position like [br, 0] (21.35 KB, patch)
2011-01-11 18:03 PST, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-01-11 14:09:52 PST
Created attachment 78597 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-11 15:37:57 PST
Comment on attachment 78597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78597&action=review > WebCore/editing/ApplyStyleCommand.cpp:571 > + Position rangeStart = firstPositionInNode(scope); Does this cause ref-churn for scope?
Ryosuke Niwa
Comment 3 2011-01-11 16:18:12 PST
Created attachment 78618 [details] cleanup
Ryosuke Niwa
Comment 4 2011-01-11 16:18:49 PST
(In reply to comment #2) > (From update of attachment 78597 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78597&action=review > > > WebCore/editing/ApplyStyleCommand.cpp:571 > > + Position rangeStart = firstPositionInNode(scope); > > Does this cause ref-churn for scope? Good point. Removed.
Ryosuke Niwa
Comment 5 2011-01-11 16:54:27 PST
Comment on attachment 78618 [details] cleanup On my second thought, I have to be more careful about what kind of Position I'm creating.
Ryosuke Niwa
Comment 6 2011-01-11 18:03:57 PST
Created attachment 78633 [details] don't generate bogus position like [br, 0]
Eric Seidel (no email)
Comment 7 2011-01-12 17:06:07 PST
Comment on attachment 78633 [details] don't generate bogus position like [br, 0] Seems sane.
Ryosuke Niwa
Comment 8 2011-01-12 19:04:21 PST
(In reply to comment #7) > (From update of attachment 78633 [details]) > Seems sane. Thanks for the review, Eric. Landing now.
Note You need to log in before you can comment on or make changes to this bug.