Bug 52161

Summary: style-queue messages are way too long for big patches
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, levin, mihaip, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Eric Seidel (no email)
Reported 2011-01-10 11:33:48 PST
style-queue messages are way too long for big patches https://bugs.webkit.org/show_bug.cgi?id=52040#c3 This is due to a change last month to pass the list of changed files to check-webkit-style. Since we want to keep that change, we should make ScriptError message-to-string functionality smarter about long argument lists.
Attachments
Patch (3.05 KB, patch)
2011-01-10 12:09 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.04 KB, patch)
2011-01-10 12:55 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-01-10 12:09:27 PST
Created attachment 78424 [details] Patch
Ojan Vafai
Comment 2 2011-01-10 12:50:05 PST
Comment on attachment 78424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78424&action=review > Tools/Scripts/webkitpy/common/system/executive.py:59 > + # We coula make this much fancier, but for now this is OK. typo: coula
Eric Seidel (no email)
Comment 3 2011-01-10 12:55:13 PST
Created attachment 78434 [details] Patch for landing
WebKit Commit Bot
Comment 4 2011-01-10 14:38:13 PST
Comment on attachment 78434 [details] Patch for landing Clearing flags on attachment: 78434 Committed r75438: <http://trac.webkit.org/changeset/75438>
WebKit Commit Bot
Comment 5 2011-01-10 14:38:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.